[webkit-reviews] review granted: [Bug 94475]=?UTF-8?Q?=20CSS=203=20=E2=80=98overflow=2Dwrap=E2=80=99=20property=20implementation=20?=: [Attachment 159916] patch v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 16:48:53 PDT 2012


Ojan Vafai <ojan at chromium.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 94475: CSS 3 ‘overflow-wrap’ property implementation
https://bugs.webkit.org/show_bug.cgi?id=94475

Attachment 159916: patch v5
https://bugs.webkit.org/attachment.cgi?id=159916&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159916&action=review


> Source/WebCore/css/StyleBuilder.cpp:2065
> +    setPropertyHandler(CSSPropertyWordWrap,
ApplyPropertyDefault<EOverflowWrap, &RenderStyle::overflowWrap, EOverflowWrap,
&RenderStyle::setOverflowWrap, EOverflowWrap,
&RenderStyle::initialOverflowWrap>::createHandler());

This could probably use a comment explaining why we are setting EOverflowWrap
for CSSPropertyWordWrap.


More information about the webkit-reviews mailing list