[webkit-reviews] review denied: [Bug 94651] ASSERT reached when TextTrack.mode is set to DISABLED : [Attachment 162355] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 94651: ASSERT reached when TextTrack.mode is set to DISABLED
https://bugs.webkit.org/show_bug.cgi?id=94651

Attachment 162355: Patch
https://bugs.webkit.org/attachment.cgi?id=162355&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162355&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:1334
> +    if (!track->hasCuesInTree()) {
> +	   beginIgnoringTrackDisplayUpdateRequests();
> +	   for (size_t i = 0; i < cues->length(); ++i)
> +	       textTrackAddCue(cues->item(i)->track(), cues->item(i));
> +	   track->setHasCuesInTree(true);
> +	   endIgnoringTrackDisplayUpdateRequests();
> +    }

Won't this prevent *any* cues from being added to the cue tree once this runs?
This will be a problem when a script creates a cue and adds it with addCue(),
when the loader delivers a track's cue data in more than one chunk, etc.

Would it work to have textTrackAddCue() only add a cue if it was not already in
the tree?