[webkit-reviews] review granted: [Bug 95521] Tables without any descendant and auto logical width should have a 0px logical width : [Attachment 162269] Proposed change #2, with moar rebaselining.

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 95521: Tables without any descendant and auto logical width should have a
0px logical width
https://bugs.webkit.org/show_bug.cgi?id=95521

Attachment 162269: Proposed change #2, with moar rebaselining.
https://bugs.webkit.org/attachment.cgi?id=162269&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162269&action=review


> Source/WebCore/ChangeLog:9
> +	   width even if we didn't have a column.

Please add information on how we match Firefox and Opera, and bug in IE.

> Source/WebCore/rendering/RenderTable.h:185
> +	       return (effectiveColumnCount + 1) * hBorderSpacing();

Please do the static_cast<LayoutUnit>(numEffCols() + 1). We don't want to
overflow here since it wont use the code path of saturated arithmetic in
fractional layout unit.