[webkit-reviews] review granted: [Bug 95888] More fixes for String::operator+=() in Debug mode : [Attachment 162329] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 95888: More fixes for String::operator+=() in Debug mode
https://bugs.webkit.org/show_bug.cgi?id=95888

Attachment 162329: Patch
https://bugs.webkit.org/attachment.cgi?id=162329&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162329&action=review


>> Source/WebCore/dom/Node.cpp:2105
>> +		string.append(attrDesc + attr);
> 
> string is an out-parameter
> are two String::append() calls better than one append and operator+()?

Can we change the outparameter type to StringBuilder?