[webkit-reviews] review granted: [Bug 95485] [chromium] Add a copy() method to CCRenderPass : [Attachment 162312] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 13:50:52 PDT 2012


Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 95485: [chromium] Add a copy() method to CCRenderPass
https://bugs.webkit.org/show_bug.cgi?id=95485

Attachment 162312: Patch
https://bugs.webkit.org/attachment.cgi?id=162312&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
R=me.

aelias: I had the same mental balking about the extra copying, but I'm willing
to take the software complexity vs. execution time tradeoff in the short term
until we figure out that it's too slow.  That being said, there's probably
simpler optimizations to decrease copying and number of allocations than
changing the ownership model, in my opinion.


More information about the webkit-reviews mailing list