[webkit-reviews] review granted: [Bug 91110] [Chromium] Call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly. : [Attachment 155372] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 91110: [Chromium] Call restrictScaleFactorToInitialScaleIfNotUserScalable
unless/until userScalable is supported directly.
https://bugs.webkit.org/show_bug.cgi?id=91110

Attachment 155372: Patch
https://bugs.webkit.org/attachment.cgi?id=155372&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155372&action=review


>
LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.ht
ml:7
> +		   alert(internals.configurationForViewport(document, 1, 320,
480, 320, 352));

Nit: It would be nice if the test said PASS or something so random people
gardening can quickly tell if the test is correct or not.

> LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:7
> +		   alert(internals.configurationForViewport(document, 1, 320,
480, 320, 352));

Ditto.