[webkit-reviews] review denied: [Bug 95756] [chromium] Enable different fling behaviour for touchscreen and touchpad : [Attachment 162304] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 95756: [chromium] Enable different fling behaviour for touchscreen and
touchpad
https://bugs.webkit.org/show_bug.cgi?id=95756

Attachment 162304: Patch
https://bugs.webkit.org/attachment.cgi?id=162304&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162304&action=review


> Source/WebCore/platform/chromium/support/PlatformGestureCurveFactory.cpp:51
> +    if (!flingAnimator && deviceSource == WebGestureEvent::Touchscreen)

early return would read better and be shorter - i.e. if the flingAnimator is
non-null at this point, construct + return a WebFlingAni..Adapter. Then you can
write the rest of the function without the !flingAnimator checks

> Source/WebKit/chromium/public/WebActiveWheelFlingParameters.h:42
> +    int sourceDevice;

wrong type - this should be a WebGestureEvent::SourceDevice, right?

> Source/WebKit/chromium/public/WebInputEvent.h:406
> +	   int sourceDevice;

int != enum - use the more specific type