[webkit-reviews] review granted: [Bug 94142] Added modifiers to distinguish between left/right Shift/Ctrl/Alt : [Attachment 162280] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Raymes Khoury <raymes at google.com>'s
request for review:
Bug 94142: Added modifiers to distinguish between left/right Shift/Ctrl/Alt
https://bugs.webkit.org/show_bug.cgi?id=94142

Attachment 162280: Patch
https://bugs.webkit.org/attachment.cgi?id=162280&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162280&action=review


> Source/WebKit/chromium/src/win/WebInputEventFactory.cpp:86
> +	   if (GetKeyState(VK_LSHIFT) & 0x8000)

Nit: I would probably make a function IsHighBitSet. It would be a little easier
to read.

> Source/WebKit/chromium/src/win/WebInputEventFactory.cpp:111
> +    ASSERT(modifier == 0

Nit: WebKit style is !modifier rather than comparing to 0.