[webkit-reviews] review granted: [Bug 93898] Add optional debug logging when we fall into/out of threaded scrolling : [Attachment 162272] update log state regardless of tile border pref (!), fix a typo

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 93898: Add optional debug logging when we fall into/out of threaded
scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898

Attachment 162272: update log state regardless of tile border pref (!), fix a
typo
https://bugs.webkit.org/attachment.cgi?id=162272&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162272&action=review


> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:392
> +    if (!supportsFixedPositionLayers() && frameView->hasFixedObjects())
> +	   reasonsForUpdatingScrollLayerPositionOnMainThread |=
ScrollingTreeState::HasFixedObjectsWithoutSupportingFixedLayers;
> +    if (supportsFixedPositionLayers() && hasNonLayerFixedObjects(frameView))

> +	   reasonsForUpdatingScrollLayerPositionOnMainThread |=
ScrollingTreeState::HasNonLayerFixedObjects;

The cool kids are calling these "viewport constrained" objects now.

> Source/WebCore/page/scrolling/mac/ScrollingTreeNodeMac.mm:353
> +	       reasonsDescription += "fixed objects,";

and sticky?