[webkit-reviews] review granted: [Bug 95839] MediaStream API: Add the local and remote description functionality to RTCPeerConnection : [Attachment 162233] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 95839: MediaStream API: Add the local and remote description functionality
to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95839

Attachment 162233: Patch
https://bugs.webkit.org/attachment.cgi?id=162233&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162233&action=review


It's a bit unfortunate that we need to build all this machinery just for
WebRTC.  The void request seems like something that could potentially be shared
between WebRTC and FileSystem, for example.  However, I don't think we need to
worry about that at this stage.

Would you be willing to fix up the variable names in a followup patch?

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:220
> +    RefPtr<RTCSessionDescription> desc =
RTCSessionDescription::create(descriptor.release());

desc -> please use complete words in variable names.