[webkit-reviews] review granted: [Bug 95735] Removed V8IsolatedContext : [Attachment 162221] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dan Carney <dcarney at google.com>'s
request for review:
Bug 95735: Removed V8IsolatedContext
https://bugs.webkit.org/show_bug.cgi?id=95735

Attachment 162221: Patch
https://bugs.webkit.org/attachment.cgi?id=162221&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162221&action=review


This looks great.  Is that test failure really caused by this patch?  Let's try
running it through the commit-queue.

> Source/WebCore/bindings/v8/ScriptController.cpp:336
> +	       ASSERT(iter->second->world()->worldId() == worldId);
> +	       ASSERT(iter->second->world()->extensionGroup() ==
extensionGroup);
> +	      return iter->second;

Bad indent.

> Source/WebCore/bindings/v8/SharedPersistent.h:47
> +	       return adoptRef(new
SharedPersistent<T>(v8::Persistent<v8::Context>::New(value)));

I would have just make this class hold a ScopedPersistent, but let's not worry
about that since we're going to remove it shortly.