[webkit-reviews] review denied: [Bug 94796] [soup] Obey setTimeoutInterval in soup backend : [Attachment 162224] setTimeoutInterval support for soup.

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 94796: [soup] Obey setTimeoutInterval in soup backend
https://bugs.webkit.org/show_bug.cgi?id=94796

Attachment 162224: setTimeoutInterval support for soup.
https://bugs.webkit.org/attachment.cgi?id=162224&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162224&action=review


Looks okay to me, but I'd prefer to have Dan and/or Sergio look at this as
well. r- because of a few small issues.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:75
> +// Use the same value as in NSURLError.h
> +#define TIMEOUT_ERROR -1001

For these type of values you should use static const int.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:772
> +	   if (d->m_firstRequest.timeoutInterval() > 0)
> +	       d->m_timeoutId =
g_timeout_add(d->m_firstRequest.timeoutInterval() * 1000,
requestTimeoutCallback, handle);

Does g_timeout_add attach the source to the default context or to the current
thread default context? Synchronous XMLHttpRequests push a new thread default
context, so this might not fire for them.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:994
> +static int requestTimeoutCallback(gpointer data)

Callbacks should return gboolean.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1007
> +    return false;

You should use FALSE here.