[webkit-reviews] review requested: [Bug 95851] [EFL] Keep placeholder text visible until first input from user. : [Attachment 162244] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 5 08:15:35 PDT 2012
Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked for review:
Bug 95851: [EFL] Keep placeholder text visible until first input from user.
https://bugs.webkit.org/show_bug.cgi?id=95851
Attachment 162244: patch
https://bugs.webkit.org/attachment.cgi?id=162244&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162244&action=review
> Source/WebCore/platform/efl/RenderThemeEfl.h:211
> + virtual bool shouldShowPlaceholderWhenFocused() const OVERRIDE { return
true; }
I think it is better to move this virtual function to virtual function list
side.
More information about the webkit-reviews
mailing list