[webkit-reviews] review denied: [Bug 95720] Simplify hitTestResultAtPoint and nodesFromRect APIs : [Attachment 162198] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 5 08:03:02 PDT 2012
Antonio Gomes <tonikitoo at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 95720: Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720
Attachment 162198: Patch
https://bugs.webkit.org/attachment.cgi?id=162198&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Idea is good, but I am really not a big fan of the
HitTestRequest::Default(true|false) new idiom.
While looking over the patch, the calls Default(true|false) were making things
equally non-obvious than before.
IMO, the APIs we improved were degraded by the suggested alternative.
More information about the webkit-reviews
mailing list