[webkit-reviews] review granted: [Bug 95834] Web Inspector: NMI: extract overloaded instrumentation members for WebCore classes from core NMI code. : [Attachment 162241] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 07:49:21 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 95834: Web Inspector: NMI: extract overloaded instrumentation members for
WebCore classes from core NMI code.
https://bugs.webkit.org/show_bug.cgi?id=95834

Attachment 162241: Patch
https://bugs.webkit.org/attachment.cgi?id=162241&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162241&action=review


> Source/WebCore/dom/MemoryInstrumentation.h:393
> +template<> void MemoryInstrumentationTraits::addInstrumentedObject<const
KURL>(MemoryInstrumentation*, const KURL* const&, MemoryObjectType,
MemoryOwningType);

Why do we need overload for T in addition to const T ?


More information about the webkit-reviews mailing list