[webkit-reviews] review denied: [Bug 95817] [Tests] We should have interactive validation of required value for the "input" element : [Attachment 162166] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 95817: [Tests] We should have interactive validation of required value for
the "input" element
https://bugs.webkit.org/show_bug.cgi?id=95817

Attachment 162166: Patch 1
https://bugs.webkit.org/attachment.cgi?id=162166&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162166&action=review


>
LayoutTests/fast/forms/date/date-interactive-validation-required-expected.txt:1

> +Test interactive validation with required attribute

The test result doesn't contain enough information.
We should mention that the test checks if an empty required field prevents form
submission and checks if a non-empty required field doesn't prevent form
submission.

> LayoutTests/fast/forms/resources/common-interactive-validation-required.js:32

> +	   testFailed('Focus should be on test element.');
> +	   return;

Need to call finishJSTest().

> LayoutTests/fast/forms/resources/common-interactive-validation-required.js:38

> +    testFailed('The form was not submitted.');

Need to call finishJSTest().

> LayoutTests/fast/forms/resources/common-interactive-validation-required.js:39

> +    return;

"return" at the end of function makes no sense.