[webkit-reviews] review denied: [Bug 88291] [EFL] Implement to support layout test of notifications. : [Attachment 145760] Patch.

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 88291: [EFL] Implement to support layout test of notifications.
https://bugs.webkit.org/show_bug.cgi?id=88291

Attachment 145760: Patch.
https://bugs.webkit.org/attachment.cgi?id=145760&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145760&action=review


> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:68
> +	       printf("DESKTOP NOTIFICATION: contents at %s\n",
notification->url().string().utf8().data());

As above comment, we have print console message in DRT side. Please move this
to DRT side.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:52
> +    static bool dumpNotification;

We don't need to use this flag if you move console message to DRT side.