[webkit-reviews] review denied: [Bug 94721] [Chromium] Scheduler will never process a commit until it receives a vsync tick. : [Attachment 161859] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 94721: [Chromium] Scheduler will never process a commit until it receives a
vsync tick.
https://bugs.webkit.org/show_bug.cgi?id=94721

Attachment 161859: Patch
https://bugs.webkit.org/attachment.cgi?id=161859&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161859&action=review


I feel that we should probably fix the commit+draw ordering problem first and
then make sure this patch doesn't break it.

At a more basic I don't really get what the vsync tick has to do with resource
updates at all.  How are the two concepts related?  My mental model was that
after getting a commit with some number of resource updates on the impl thread,
we have to spend some time doing uploads until we're up to the last batch at
which point we complete the commit + do the last batch of updates.  None of
this should have anything to do with vsync, should it?	Vsync is just about
when we draw.

> Source/WebCore/platform/graphics/chromium/cc/CCScheduler.cpp:146
> +	   m_stateMachine.setCanBeginFrame(true);

This looks a bit odd - what's it for?