[webkit-reviews] review granted: [Bug 95705] CSS3 calc: expressions with 'em' units do not zoom correctly. : [Attachment 161963] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 4 18:42:44 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 95705: CSS3 calc: expressions with 'em' units do not zoom correctly.
https://bugs.webkit.org/show_bug.cgi?id=95705
Attachment 161963: Patch
https://bugs.webkit.org/attachment.cgi?id=161963&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161963&action=review
>> LayoutTests/css3/calc/zoom-with-em.html:19
>> + shouldEvaluateTo(calc.offsetWidth + "", nocalc.offsetWidth + "");
>
> Can I do something better here? This feels a wee bit dodgy :(
You could toString or String() them. But, meh, doesn't really matter.
More information about the webkit-reviews
mailing list