[webkit-reviews] review denied: [Bug 95661] [Chromium] Multiple commits without invalidation allowed per redraw. : [Attachment 161856] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 95661: [Chromium] Multiple commits without invalidation allowed per redraw.
https://bugs.webkit.org/show_bug.cgi?id=95661

Attachment 161856: Patch
https://bugs.webkit.org/attachment.cgi?id=161856&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161856&action=review


> Source/WebCore/platform/graphics/chromium/cc/CCScheduler.cpp:94
>      m_stateMachine.beginFrameComplete();
> +    m_stateMachine.setCanBeginFrame(false);

These still seem redundant to me. Telling the state machine beginFrameComplete
should put us into the waiting for draw state.	Once we get into this state,
how are we returning ACTION_BEGIN_FRAME before we actually draw?  I think
fixing that will fix this class of bugs without needing redundant state sets.