[webkit-reviews] review granted: [Bug 94142] Added modifiers to distinguish between left/right Shift/Ctrl/Alt : [Attachment 161493] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Raymes Khoury <raymes at google.com>'s
request for review:
Bug 94142: Added modifiers to distinguish between left/right Shift/Ctrl/Alt
https://bugs.webkit.org/show_bug.cgi?id=94142

Attachment 161493: Patch
https://bugs.webkit.org/attachment.cgi?id=161493&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161493&action=review


> Source/WebKit/chromium/ChangeLog:20
> +	   modifiers. Since this only changes internal representation, no new
> +	   tests are added.

Can you add a 'why' to the ChangeLog entry?  Saying that you need this for
plugins would be sufficient.

> Source/WebKit/chromium/src/win/WebInputEventFactory.cpp:51
> +    if (wparam == VK_SHIFT) {
> +	   if (GetKeyState(VK_LSHIFT))
> +	       modifier = WebInputEvent::IsLeft;
> +	   else if (GetKeyState(VK_RSHIFT))

Should we move all of this into the switch below?

> Source/WebKit/chromium/src/win/WebInputEventFactory.cpp:104
> +    ASSERT(modifier

Is this assert correct? Can't modifier be 0?