[webkit-reviews] review granted: [Bug 93870] [CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes. : [Attachment 162072] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Max Vujovic <mvujovic at adobe.com>'s
request for review:
Bug 93870: [CSS Shaders] Implement multiply, screen, darken, lighten,
difference, exclusion blend modes.
https://bugs.webkit.org/show_bug.cgi?id=93870

Attachment 162072: Patch
https://bugs.webkit.org/attachment.cgi?id=162072&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162072&action=review


Awesome reduction with the expressions! r=me. Just one question inline.

> Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:191

> +	   expression = "Cb + Cs - 2.0 * Cb * Cs";

Usually the style is 2, can Cb and Cs be integer?