[webkit-reviews] review denied: [Bug 95747] [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection : [Attachment 162040] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied otcheung at rim.com's request for review:
Bug 95747: [BlackBerry] Browser is not sending secured Cookie back to server
over HTTPS connection
https://bugs.webkit.org/show_bug.cgi?id=95747

Attachment 162040: Patch
https://bugs.webkit.org/attachment.cgi?id=162040&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162040&action=review


Looks good, some stuff to fix still.

> Source/WebCore/ChangeLog:2
> +

One empty line too many.

> Source/WebCore/ChangeLog:11
> +	   The problem was if the browser has never saved a secure protocol,

Can you rephrase this? It seems a bit terse.

> Source/WebCore/ChangeLog:18
> +	   funciton.

Typo: function.

> Source/WebCore/platform/blackberry/CookieManager.cpp:212
> +    // Set the map to the non-secure version, so it'll search the mapping
for a secure cookie

Lacks period.