[webkit-reviews] review denied: [Bug 95649] Web Inspector: CodeGeneratorInspector.py: support asynchronous command implementation : [Attachment 161834] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 95649: Web Inspector: CodeGeneratorInspector.py: support asynchronous
command implementation
https://bugs.webkit.org/show_bug.cgi?id=95649

Attachment 161834: Patch
https://bugs.webkit.org/attachment.cgi?id=161834&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161834&action=review


Please fix the failing tests and attach an example diff of the generated code.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1871
> +	   void sendFailure(ErrorString);

const ErrorString&

> Source/WebCore/inspector/CodeGeneratorInspector.py:1874
> +	   virtual ~CallbackBase();

style: destructor should go right after the constructor

> Source/WebCore/inspector/CodeGeneratorInspector.py:1876
> +	   void sendIfActive(PassRefPtr<InspectorObject> partialMessage,
ErrorString invocationError);

const ErrorString& also partialMessage can be just InspectorObject*

> Source/WebCore/inspector/CodeGeneratorInspector.py:1953
> +    void sendResponse(long callId, PassRefPtr<InspectorObject> result,
ErrorString invocationError);

|result| type should be InspectorObject* instead of
PassRefPtr<InspectorObject>.

> Source/WebCore/inspector/CodeGeneratorInspector.py:2203
> +    sendIfActive(PassRefPtr<InspectorObject>(), error);

sendIfActive(0, error)

> Source/WebCore/inspector/CodeGeneratorInspector.py:2208
> +    return !m_alreadySent && m_backendImpl->isActive();

In theory we may end up sending response for a long-running command to a
different frontend. Consider the following sequence: FE1 attaches and sends
request1, then FE1 is detached and FE2 is attached, now reponse for the
request1 is sent.

> Source/WebCore/inspector/CodeGeneratorInspector.py:2903
> +					  None, decl_parameter_list,

style nit: the line should be aligned by ( above.

> Source/WebCore/inspector/CodeGeneratorInspector.py:2949
> +								       
setter_argument)

nit: weir alignment