[webkit-reviews] review denied: [Bug 95549] [GTK] Add API to get/set the security policy of a given URI scheme : [Attachment 161654] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 95549: [GTK] Add API to get/set the security policy of a given URI scheme
https://bugs.webkit.org/show_bug.cgi?id=95549

Attachment 161654: Patch
https://bugs.webkit.org/attachment.cgi?id=161654&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161654&action=review


Looks good to me! Just a couple comments.

> Source/WebKit/gtk/webkit/webkitglobals.h:149
> + * @WEBKIT_SECURITY_POLICY_NO_ACCESS: Pages loaded with this URI scheme

WEBKIT_SECURITY_POLICY_NO_ACCESS seems a bit too broad. Perhaps
WEBKIT_SECURITY_POLICY_NO_ACCESS_TO_OTHER_SCHEMES or something better?

> Source/WebKit/gtk/webkit/webkitglobals.h:155
> + * @WEBKIT_SECURITY_POLICY_CORS_ENABLED: URI scheme that can be sent CORS
requests.

Agree with Mario here that you might want to link to the CORS spec.