[webkit-reviews] review granted: [Bug 94990] Share immutable ElementAttributeData between elements with identical attributes. : [Attachment 161939] Patch!!11

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 94990: Share immutable ElementAttributeData between elements with identical
attributes.
https://bugs.webkit.org/show_bug.cgi?id=94990

Attachment 161939: Patch!!11
https://bugs.webkit.org/attachment.cgi?id=161939&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=161939&action=review


Nice. r=me

> Source/WebCore/dom/Document.cpp:6178
> +class ImmutableAttributeDataCacheKey {

Document is super bloaty. Would be nice to factor this a separate file/class.

> Source/WebCore/dom/Document.cpp:6192
> +    bool operator!=(ImmutableAttributeDataCacheKey& other) const

const

> Source/WebCore/dom/Document.cpp:6235
> +    if (!cacheHash || cacheIterator->second)

The logic here is bit strange. I suspect it could be written in a nicer way.