[webkit-reviews] review denied: [Bug 95692] [WK2] WebProcess crashes when plugin is not initialized. : [Attachment 161937] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Andras Becsi <abecsi at webkit.org>'s
request for review:
Bug 95692: [WK2] WebProcess crashes when plugin is not initialized.
https://bugs.webkit.org/show_bug.cgi?id=95692

Attachment 161937: Patch
https://bugs.webkit.org/attachment.cgi?id=161937&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
I would like to see steps to reproduce this crash and a backtrace of the crash.


There's active work going on in this area so it's important to understand the
details of what you've found and not just wallpaper over it.

More specifically, PluginViews are created with m_plugin set to the Plugin that
last their entire lifetime, so it's surprising to see that m_plugin might be
null.

The only time it can be cleared is if the plug-in fails to initialize and then
the PluginView is still used after that case.

Again, please give details on how this reproduces.