[webkit-reviews] review requested: [Bug 95618] [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex : [Attachment 161899] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 95618: [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
https://bugs.webkit.org/show_bug.cgi?id=95618

Attachment 161899: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=161899&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Simple patch to fix this issue, by protecting us against the situation exposed
here: a selector which is not rendered through a HTML <select> element.

I propose this patch because the current code was assuming that was the case (a
HTML <select> element was always there), which seems to be plainly wrong, as
this situation clearly exposes. Of course, some better improvements could be
done (e.g. supporting WAI-ARIA selectors), but I think the focus should be now
put on fixing this crash, and so that's what this patch does, by ensuring we
only emit the signal when such an assumption is right.