[webkit-reviews] review denied: [Bug 95654] Web Inspector: Remove toolbar icons by default, and add settings options to show them : [Attachment 161880] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied dubroy at chromium.org's request
for review:
Bug 95654: Web Inspector: Remove toolbar icons by default, and add settings
options to show them
https://bugs.webkit.org/show_bug.cgi?id=95654

Attachment 161880: Patch
https://bugs.webkit.org/attachment.cgi?id=161880&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161880&action=review


> Source/WebCore/ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

Please attach screenshots with changes to the UI.

> Source/WebCore/inspector/front-end/Settings.js:47
> +    showUseToolbarIcons: true

I don't think we need this.

> Source/WebCore/inspector/front-end/SettingsScreen.js:254
> +	  
p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show toolbar
icons"), WebInspector.settings.useToolbarIcons));

Strings should go to the WebCore/English.lproj/localizedStrings.js

> Source/WebCore/inspector/front-end/Toolbar.js:167
> +    _useToolbarIconsSettingChanged: function(event) {

{ on the next line.

> Source/WebCore/inspector/front-end/Toolbar.js:171
> +    _setIconsVisible: function(visible) {

ditto

> Source/WebCore/inspector/front-end/Toolbar.js:249
> +	       if (toolbarItems[i].offsetTop > 1)

Should we compare things with 1 pixel? What is the reason behind this change?

> Source/WebCore/inspector/front-end/inspector.css:68
> +#toolbar.with-icons + #main {

We don't use sibling selectors.

> Source/WebCore/inspector/front-end/inspector.css:99
> +body.compact #toolbar.with-icons + #main {

ditto

> Source/WebCore/inspector/front-end/inspector.css:208
> +    /* A line height of 0 allows precise text positioning using padding. */

I was hoping that this change would be simpler. Is there a way to optimize the
styles here?