[webkit-reviews] review denied: [Bug 94925] [EFL][UT] Updating ut framework fo wk1 : [Attachment 160433] Updating ut framework for wk1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 2 22:53:55 PDT 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 94925: [EFL][UT] Updating ut framework fo wk1
https://bugs.webkit.org/show_bug.cgi?id=94925

Attachment 160433: Updating ut framework for wk1
https://bugs.webkit.org/attachment.cgi?id=160433&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160433&action=review


> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h:46
>      EWKTestView(const EWKTestView&);

Please add explicit.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h:49
> +    int m_useX11Window;

why int ?


More information about the webkit-reviews mailing list