[webkit-reviews] review denied: [Bug 95660] [Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels : [Attachment 161862] Patch 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 2 22:26:33 PDT 2012


Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 95660: [Forms] Empty visible value of AM/PM field of multiple fields time
input UI should display variable number of "-" based on maximum number of
labels
https://bugs.webkit.org/show_bug.cgi?id=95660

Attachment 161862: Patch 4
https://bugs.webkit.org/attachment.cgi?id=161862&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161862&action=review


> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:46
> +	builder.reserveCapacity(maximumLength);

wrong indentation

> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:49
> +    return AtomicString(builder.toString());

should use builder.toAtomicString().


More information about the webkit-reviews mailing list