[webkit-reviews] review denied: [Bug 95660] [Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels : [Attachment 161857] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 95660: [Forms] Empty visible value of AM/PM field of multiple fields time
input UI should display variable number of "-" based on maximum number of
labels
https://bugs.webkit.org/show_bug.cgi?id=95660

Attachment 161857: Patch 1
https://bugs.webkit.org/attachment.cgi?id=161857&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161857&action=review


> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:119
>  String DateTimeSymbolicFieldElement::visibleEmptyValue() const

Building the string every time is not efficient though this function is not so
hot.

> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:123
> +	   maximumLength = std::max(maximumLength, m_symbols[index].length());

I think numGraphemeClusters(m_symbols[index]) is better than
m_symbols[index].length().

> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:124
> +    StringBuilder builder;

should have builder.reserveCapacity(maximumLength);.