[webkit-reviews] review granted: [Bug 95652] Don't create access error strings if there is no access error : [Attachment 161839] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 2 01:02:13 PDT 2012


Adam Barth <abarth at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 95652: Don't create access error strings if there is no access error
https://bugs.webkit.org/show_bug.cgi?id=95652

Attachment 161839: the patch
https://bugs.webkit.org/attachment.cgi?id=161839&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I would just remove the |result| temporary and just early return if
shouldAllowAccessToFoo returns true.  Thanks for fixing my regression.


More information about the webkit-reviews mailing list