[webkit-reviews] review granted: [Bug 95565] MediaStream API: Add Ice-related functionality to RTCPeerConnection : [Attachment 161688] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 95565: MediaStream API: Add Ice-related functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95565

Attachment 161688: Patch
https://bugs.webkit.org/attachment.cgi?id=161688&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161688&action=review


> Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.idl:30
> +	  readonly attribute RTCIceCandidate candidate;

Bad indent.  I think we have this in a bunch of event interfaces.

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:149
> +void RTCPeerConnection::addIceCandidate(PassRefPtr<RTCIceCandidate>
prpIceCandidate, ExceptionCode& ec)

It's not clear to me why this function need to take a reference to the
RTCIceCandidate

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:190
> +	   return "new";

ASCIILiteral