[webkit-reviews] review denied: [Bug 96335] Clicking a scrollbar unfocuses the current activeElement : [Attachment 164807] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 96335: Clicking a scrollbar unfocuses the current activeElement
https://bugs.webkit.org/show_bug.cgi?id=96335

Attachment 164807: Patch
https://bugs.webkit.org/attachment.cgi?id=164807&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164807&action=review


>> Source/WebCore/page/EventHandler.cpp:2265
>> +	    if ((!element || !element->isFormControlElement()) &&
isInsideScrollbar(mouseEvent.position()))
> 
> We probably also want to move focus for contentEditable elements?

Firefox actually looks at whether the element is mouseFocusable. So, if we're
going to have a check here, it should be that.