[webkit-reviews] review granted: [Bug 100894] Implement optional arguments in AudioBufferSourceNode start() method : [Attachment 171727] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 100894: Implement optional arguments in AudioBufferSourceNode start()
method
https://bugs.webkit.org/show_bug.cgi?id=100894

Attachment 171727: Patch
https://bugs.webkit.org/attachment.cgi?id=171727&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171727&action=review


Looks good. One minor comment. r=me

> LayoutTests/webaudio/audiobuffersource-start.html:62
> +    if (test.offsetFrame == "none" && test.durationFrames == "none") {

You could consider leaving these properties undefined and check for "===
undefined". Not a big deal either way, but a simple typo in the string "none"
could cause bugs.