[webkit-reviews] review requested: [Bug 100674] [EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS : [Attachment 171718] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 31 14:13:04 PDT 2012


Yael <yael.aharon.m at gmail.com> has asked  for review:
Bug 100674: [EFL][WK2] Allow using ACCELERATED_COMPOSITING without
COORDINATED_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=100674

Attachment 171718: Patch
https://bugs.webkit.org/attachment.cgi?id=171718&action=review

------- Additional Comments from Yael <yael.aharon.m at gmail.com>
Make a distinction between calling ewk_view_base_add and ewk_view_smart_add.
Calling ewk_view_base_add creates a desktop style view, that does not support
fixed layout size, while calling ewk_view_smart_add does support fixed layout
size.
As a result, WebKitTestRunner and the inspector window do not support fixed
layout size, while MiniBrowser does. This change allows many DumpAsText layout
tests to pass without modification, when AC is enabled.

I chose to make this distinction, to avoid adding a new public API.


More information about the webkit-reviews mailing list