[webkit-reviews] review denied: [Bug 100675] [chromium] Provide WebKit API interface for platform gesture curves : [Attachment 171531] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 100675: [chromium] Provide WebKit API interface for platform gesture curves
https://bugs.webkit.org/show_bug.cgi?id=100675

Attachment 171531: Patch
https://bugs.webkit.org/attachment.cgi?id=171531&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171531&action=review


One more round and then we should be good to go.

> Source/Platform/chromium/public/WebGestureCurve.h:41
> +    // Returns a name of the curve for use in tracing.
> +    virtual const char* traceName() const = 0;

I don't think you should add this - put the tracing on the implementation side
if you want to trace with additional information known only by the
implementation. The lifetime of the WebGestureCurve is the same as that of the
animation so you will get the same data out.  This isn't logically part of the
API.

> Source/WebKit/chromium/src/WebActiveGestureAnimation.cpp:1
> +/*

This file doesn't have any dependencies on things in Source/WebKit/ or
Source/WebCore and is implementing a Platform API, so it should be in
Source/Platform/chromium/src

> Source/WebKit/chromium/src/WebActiveGestureAnimation.h:1
> +/*

This file as well doesn't have any dependencies on things in Source/WebKit/ or
Source/WebCore and is implementing a Platform API, so it should be in
Source/Platform/chromium/src