[webkit-reviews] review granted: [Bug 100875] [chromium] Make WebLayerTreeView::adjustEventPointForPinchZoom pure virtual. : [Attachment 171701] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 31 12:29:31 PDT 2012


James Robinson <jamesr at chromium.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 100875: [chromium] Make WebLayerTreeView::adjustEventPointForPinchZoom pure
virtual.
https://bugs.webkit.org/show_bug.cgi?id=100875

Attachment 171701: Patch
https://bugs.webkit.org/attachment.cgi?id=171701&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171701&action=review


Have you rolled the implementation into Source/WebKit/chromium/DEPS?

> Source/Platform/chromium/public/WebLayerTreeView.h:101
> +    virtual WebFloatPoint adjustEventPointForPinchZoom(const WebFloatPoint&)
const =0;

need a space before the 0


More information about the webkit-reviews mailing list