[webkit-reviews] review denied: [Bug 100863] Make defaultTypesettingFeatures a proper setting : [Attachment 171669] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 100863: Make defaultTypesettingFeatures a proper setting
https://bugs.webkit.org/show_bug.cgi?id=100863

Attachment 171669: Patch
https://bugs.webkit.org/attachment.cgi?id=171669&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171669&action=review


This breaks Font::setDefaultTypesettingFeatures().

> Source/WebCore/platform/graphics/FontDescription.h:76
> +    enum KerningState { AutoKerning, NormalKerning, NoneKerning };

This renaming appears unrelated to what this patch is trying to do, so it
doesn’t belong in this patch.

> Source/WebCore/platform/graphics/FontDescription.h:238
> +    unsigned m_defaultTypesettingFeatures : 2; // Used to control what auto
kerning and normal ligatures implies.

What makes this a property of a FontDescription?