[webkit-reviews] review granted: [Bug 100853] [V8] Cleanup V8DOMWrapper::getCachedWrapper : [Attachment 171643] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 31 08:41:07 PDT 2012


Adam Barth <abarth at webkit.org> has granted Dan Carney <dcarney at google.com>'s
request for review:
Bug 100853: [V8] Cleanup V8DOMWrapper::getCachedWrapper
https://bugs.webkit.org/show_bug.cgi?id=100853

Attachment 171643: Patch
https://bugs.webkit.org/attachment.cgi?id=171643&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171643&action=review


>> Source/WebCore/bindings/v8/V8DOMWrapper.h:-115
>> -		    if (LIKELY(!wrapper.IsEmpty()))
> 
> Why is this branch redundant? This branch will fail and has to fall back to
the following slow path in a case where we are in the main world and a wrapper
has not yet created for a given node, won't it?

You're right Kentaro, but this function is only responsible for getting the
cached wrapper.  The caller of this function will create the wrapper if this
function returns an empty handle.


More information about the webkit-reviews mailing list