[webkit-reviews] review denied: [Bug 100334] [WK2] Make WebVibrationProxy to be a member of WebPageProxy. : [Attachment 171610] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 100334: [WK2] Make WebVibrationProxy to be a member of WebPageProxy.
https://bugs.webkit.org/show_bug.cgi?id=100334

Attachment 171610: Patch
https://bugs.webkit.org/attachment.cgi?id=171610&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
This looks mostly good, but I think the WebVibrationProxy should be the message
receiver. The whole point of the MessageReceiver design is to avoid having a
bunch of #ifdefs inside didReceiveMessage.

This means that you'll have to create the WebVibrationProxy eagerly in the
WebPageProxy constructor. I don't think that should be a big problem though.