[webkit-reviews] review denied: [Bug 100844] [Qt] Reduce the number of clean builds : [Attachment 171646] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 100844: [Qt] Reduce the number of clean builds
https://bugs.webkit.org/show_bug.cgi?id=100844

Attachment 171646: Patch
https://bugs.webkit.org/attachment.cgi?id=171646&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171646&action=review


> Tools/Scripts/webkitdirs.pm:2349
> +    if ($needsIncrementalBuild && !$maybeNeedsCleanBuild) {

Doesn't this mean that when a file changes, we won't do an incremental build,
only a regular build? I think we can leave it like it was.

> Tools/Scripts/webkitdirs.pm:2388
> +	   print "Calling '$command wipeclean' in " . $dir . "\n\n";

And then you need to reconstruct command here, since it will have "incremental"
in it at this point.