[webkit-reviews] review granted: [Bug 100844] [Qt] Reduce the number of clean builds : [Attachment 171627] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 100844: [Qt] Reduce the number of clean builds
https://bugs.webkit.org/show_bug.cgi?id=100844

Attachment 171627: Patch
https://bugs.webkit.org/attachment.cgi?id=171627&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171627&action=review


This opens us up to false positive incremental builds. If you're fine with
that, then let's try it. A few nitpicks:

> Tools/Scripts/webkitdirs.pm:2337
> +		   print "Change to $_ detected, maybe clean build needed.\n";

"clean build may be needed"

> Tools/Scripts/webkitdirs.pm:2390
> +	   $result = system "$command wipeclean incremental";

What's the behaviour of make when passing multiple targets? Is there a chance
it will try to parallelise them, or is this equivalent to make foo && make bar?