[webkit-reviews] review granted: [Bug 96894] Add DeviceController base-class to remove duplication of DeviceXXXControler : [Attachment 171580] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 96894: Add DeviceController base-class to remove duplication of
DeviceXXXControler
https://bugs.webkit.org/show_bug.cgi?id=96894

Attachment 171580: Patch
https://bugs.webkit.org/attachment.cgi?id=171580&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171580&action=review


looks god.

> Source/WebCore/loader/EmptyClients.h:576
> +    virtual void startUpdating() { }

Use OVERRIDE here.

> Source/WebCore/loader/EmptyClients.h:577
> +    virtual void stopUpdating() { }

DItto.