[webkit-reviews] review denied: [Bug 100633] Text Autosizing: Add Text Autosizing APIs for WK2 : [Attachment 171548] Fixed patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Jaehun Lim <ljaehun.lim at samsung.com>'s
request for review:
Bug 100633: Text Autosizing: Add Text Autosizing APIs for WK2
https://bugs.webkit.org/show_bug.cgi?id=100633

Attachment 171548: Fixed patch
https://bugs.webkit.org/attachment.cgi?id=171548&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171548&action=review


> Source/WebKit2/UIProcess/API/C/WKPreferences.h:229
> +// Defaults to 1.0
> +WK_EXPORT void
WKPreferencesSetTextAutosizingFontScaleFactor(WKPreferencesRef preferences,
float fontScaleFactor);
> +WK_EXPORT float
WKPreferencesGetTextAutosizingFontScaleFactor(WKPreferencesRef preferences);

All the other preferences use double, why use float here?  I'd prefer we keep
it consistent and use double.