[webkit-reviews] review denied: [Bug 100563] garden-o-matic should support gardening a single port and specifying how to deal with overwritten baselines : [Attachment 171564] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 100563: garden-o-matic should support gardening a single port and
specifying how to deal with overwritten baselines
https://bugs.webkit.org/show_bug.cgi?id=100563

Attachment 171564: Patch
https://bugs.webkit.org/attachment.cgi?id=171564&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171564&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/config.js:151
> +	       if (config.currentBuilder)
> +		   return builderName == config.currentBuilder;
> +	       

Lets not have this logic in this function. Lets instead have a helper function
that is the sole caller of builderApplies and make builderApplies private
perhaps.

> Tools/Scripts/webkitpy/tool/commands/gardenomatic.py:46
> +	       # FIXME: This assumes that the implementation is the first part
of options.platform.

I'm not sure what you mean by "implementation" here.

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:66
> +	       arg_string = '?' + '&'.join("%s=%s" % (key, urllib.quote(value))
for (key, value) in args.items())

Can you just use urllib.urlencode(args) or something like that here?