[webkit-reviews] review granted: [Bug 97398] Script run from an isolated world should bypass a page's CSP. : [Attachment 171408] Rebased.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 15:04:51 PDT 2012


Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 97398: Script run from an isolated world should bypass a page's CSP.
https://bugs.webkit.org/show_bug.cgi?id=97398

Attachment 171408: Rebased.
https://bugs.webkit.org/attachment.cgi?id=171408&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171408&action=review


My only hesitation with this patch is that we're leaning on V8's static state
to implicitly remember whether we're in an isolated world.  That might be
tricky to implement in JSC.  We should try the JSC implementation soon to make
sure we don't need to restructure things too much.

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:75
> +
> +

These blank lines look extra


More information about the webkit-reviews mailing list