[webkit-reviews] review denied: [Bug 99393] Add support for 8 bit TextRuns for ports using HarfBuzz or HarfBuzz NG : [Attachment 168822] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 30 15:04:07 PDT 2012
Eric Seidel <eric at webkit.org> has denied Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 99393: Add support for 8 bit TextRuns for ports using HarfBuzz or HarfBuzz
NG
https://bugs.webkit.org/show_bug.cgi?id=99393
Attachment 168822: Patch
https://bugs.webkit.org/attachment.cgi?id=168822&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168822&action=review
> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.h:74
> + Vector<String> m_stringsFor8BitRuns;
I don't think this is necessary. We should chat about this patch when your'e
back.
More information about the webkit-reviews
mailing list