[webkit-reviews] review granted: [Bug 100714] Temporarily restrict use of ImageBufferSkia::copyToPlatformTexture until bugs resolved : [Attachment 171512] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 100714: Temporarily restrict use of ImageBufferSkia::copyToPlatformTexture
until bugs resolved
https://bugs.webkit.org/show_bug.cgi?id=100714

Attachment 171512: Patch
https://bugs.webkit.org/attachment.cgi?id=171512&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171512&action=review


OK, bots willing.  It's a shame that there isn't a failing test that could go
green (maybe our Mesa layer allows 5551 to be bound for rendering?)  r=me

> Source/WebCore/platform/graphics/ImageBuffer.h:123
> +	   // FIXME: current implementations of this method have the
restriction that they only work
> +	   // with textures that are RGBA format and UNSIGNED_BYTE type.

Nit:  maybe we should just say color-renderable textures?